Fix for TypeError (missing method: String#contains) #16

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

Hi Michael,

I used your "rake build" task to build an unminified version of Shadowbox to help us track down a bug in an upcoming site of ours. In the process, I inadvertently used HEAD instead of v3.0.3, and ended up finding and fixing the following bug:

Uncaught TypeError: Object Shockwave Flash,Shockwave Flash,QuickTime Plug-in 7.6.6,Java Plug-In 2 for NPAPI Browsers,Chrome PDF Viewer,iPhotoPhotocast,Default Plug-in has no method 'contains'

Just a simple Array to String conversion problem. I hope this helps!

Thanks for maintaining Shadowbox!

Best wishes,

Ben

Benjamin Oakes
Software Developer
Hedgeye Risk Management
http://www.hedgeye.com/
GitHub: @benjaminoakes
Twitter: @benjaminoakes

@benjaminoakes benjaminoakes Bugfix for: Uncaught TypeError: Object Shockwave Flash,Shockwave Flas…
…h,QuickTime Plug-in 7.6.6,Java Plug-In 2 for NPAPI Browsers,Chrome PDF Viewer,iPhotoPhotocast,Default Plug-in has no method 'contains'
65bac41

Any update on this?

@ghost

ghost commented Sep 23, 2012

This is not a fix, the prototype contains has been fixed in the source, now you must remove line 1487 from the source. thus rollback change hedgeyedev/shadowbox@65bac41

This has been open for over a year, and we've been working around it successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment