Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/new metrics #11

Merged
merged 3 commits into from Mar 17, 2020
Merged

refactor/new metrics #11

merged 3 commits into from Mar 17, 2020

Conversation

@mjavier2k
Copy link
Owner

mjavier2k commented Mar 17, 2020

  • Refactor ListActiveFaults metrics
  • Implement ListISCSISessions metrics
mjavier2k added 2 commits Mar 16, 2020
@mjavier2k mjavier2k requested a review from neufeldtech Mar 17, 2020
@@ -173,7 +173,7 @@ func TestClient_ListClusterActiveFaults(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
defer gock.Off()
//gock.Observe(gock.DumpRequest)
gock.Observe(gock.DumpRequest)

This comment has been minimized.

Copy link
@neufeldtech

neufeldtech Mar 17, 2020

Collaborator

Probably want to leave this commented?

for _, f := range gotRaw.Result.Faults {
severity[f.Severity]++
fmt.Println(f.Code)

This comment has been minimized.

Copy link
@neufeldtech

neufeldtech Mar 17, 2020

Collaborator

Do you need this loop if it's just printing things to the console?

@mjavier2k mjavier2k merged commit c76c8ae into master Mar 17, 2020
2 checks passed
2 checks passed
Build
Details
Build
Details
@mjavier2k mjavier2k deleted the refactor-faults branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.