Field with errors does not display inline messages with input as :check_boxes #102

Closed
jjp opened this Issue Mar 20, 2014 · 6 comments

Projects

None yet

3 participants

@jjp
jjp commented Mar 20, 2014

Scenario:
Given a field that has errors
When I display the field within an input type as :check_boxes and configuring to display errors inline - I expect to the the error string below that field.

With formtastic-bootstrap (3.0.0) that is not the case. I do not see the error message.

I do have a proposed fix for this and can send a pull request, but I'd like to verify that my fix does not break anything. However, I can't seem to get specs to run properly given my recently forked clone.

Can someone provide guidance on how to get the test suite to run?

Current suite fails with:
uninitialized constant Rails::VERSION (NameError)

Attempts to fix this just cause more issues.

@sodabrew
Collaborator

Unfortunately the specs are not in great shape right now. Please do open a PR and we can help work through it.

@jjp
jjp commented Mar 27, 2014

Pull request sent.

@sodabrew sodabrew added a commit that referenced this issue Apr 7, 2014
@sodabrew sodabrew Merge branch 'pr/103'
Potential fix for issue #102
3fe8c07
@sodabrew
Collaborator
sodabrew commented Apr 7, 2014

Please let me know if the merged version of #103 works, and we'll close out this bug.

@jjp
jjp commented Apr 17, 2014

Looks A-OK now. Thx!

@sodabrew
Collaborator

Thanks for confirming!

@sodabrew sodabrew closed this Apr 17, 2014
@waiting-for-dev

Hey, it seems is is still an issue in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment