Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Move help-inline error sentences inside their control's div #43

Merged
merged 1 commit into from Feb 2, 2013

Conversation

Projects
None yet
3 participants
Contributor

jisk commented Nov 4, 2012

Issue #42, move the help-inline items to inside their control's div.
Based on Twitter Bootstrap documentation

@jisk jisk Move help-inline error sentences inside their control's div
Issue #42, move the help-inline items to inside their control's div.
Based on Twitter Bootstrap documentation
da6d1f3

obduk commented Nov 19, 2012

@jisk I was also having this problem. I have checked out your pull request and checked it does work.

I would guess it's not being merged as it doesn't have any tests, if you don't have time or need help, I would be willing to help?

Owen

Contributor

jisk commented Nov 20, 2012

@obduk Yeah, sorry, I don't have any time to write a test for this - if you want to, more than happy for you to do it. I was just putting the code out there for others to use.

Collaborator

sodabrew commented Feb 2, 2013

Tests appreciated, and I'm going to merge this now.

@sodabrew sodabrew added a commit that referenced this pull request Feb 2, 2013

@sodabrew sodabrew Merge pull request #43 from jisk/errors_inside_div
Move help-inline error sentences inside their control's div
86601d9

@sodabrew sodabrew merged commit 86601d9 into mjbellantoni:master Feb 2, 2013

@nbrew nbrew pushed a commit to nbrew/formtastic-bootstrap that referenced this pull request Apr 19, 2013

@sodabrew sodabrew Merge pull request #43 from jisk/errors_inside_div
Move help-inline error sentences inside their control's div
9b13812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment