Permalink
Commits on Nov 16, 2011
  1. add full-height block

    committed Nov 16, 2011
Commits on Nov 15, 2011
  1. comment tests

    committed Nov 15, 2011
  2. handle special case where min=max

    plus tests
    committed Nov 15, 2011
  3. Use rational arithmetic instead of bc

    Use rational arithmetic throughout to avoid shelling out to bc, which
    is slow and apparently nonportable.  Instead of dealing with decimal
    numbers like 4.35, we convert 4.35 to 435 / 100 and deal with the
    integers 435 and 100.
    
    It is ridiculous, but it is a lot faster.
    
    All the tests pass now.
    committed Nov 15, 2011
  4. fix expected test result for decimal test

    Since 5.5 is the minimal input value, it should be at the baseline,
    and should have the shortest possible tick, not the second-shortest.
    committed Nov 15, 2011
  5. adjust expected test result

    The input data were 1,5,22,13,5
    
    Say 1 maps to a bar of height 0 and 22 to a bar of height 6.
    Then the linear mapping has that x :-> (x-1) * 2/7.
    
    So 13 :-> 24/7 = 3.43.  The test data had it displayed as a bar of
    height 4, and I changed it to a bar of height 3.
    committed Nov 15, 2011
  6. cache min and max inputs

    committed Nov 15, 2011
  7. fix arithmetic errors

    also use division instead of looping with trial multiplication
    committed Nov 15, 2011
  8. update README

    holman committed Nov 15, 2011
  9. add space tests

    holman committed Nov 15, 2011
  10. Merge branch 'allow_spaced_input' of https://github.com/patricklucas/…

    …spark into patricklucas-allow_spaced_input
    holman committed Nov 15, 2011
  11. (failing) test for decimals

    holman committed Nov 15, 2011
  12. Keep individual numbers separate

    Instead of interpreting input "1 3 2 6 8" as "13268", treat spaces
    as commas then condense.
    patricklucas committed Nov 15, 2011
  13. Change back to using 'test' for string equality

    Minimizes this branches overall change.
    patricklucas committed Nov 15, 2011
  14. Allow spaced input

    This allows input like "1, 2, 4, 7, 9" which is sometimes useful
    with longer lists.
    patricklucas committed Nov 15, 2011
  15. Merge pull request #25 from peff/22439644fb39de086482d71d36a9251966af…

    …fc67
    
    obvious shell cleanups
    holman committed Nov 15, 2011
  16. print sparks incrementally instead of building string

    This shaves a few lines from the print_ticks function. We
    use "printf" instead of "echo -n" as the former is more
    portable (although we are hopelessly tied to bash due to the
    use of arrays, anyway, so either would be fine).
    peff committed Nov 15, 2011
  17. use shell arithmetic expansion

    This is way faster than invoking bc repeatedly.
    
    Before:
    
      $ DATA=1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20
      $ time spark.old $DATA >/dev/null
      real    0m1.018s
      user    0m0.020s
      sys     0m0.060s
    
    After:
    
      $ time spark $DATA >/dev/null
      real    0m0.089s
      user    0m0.000s
      sys     0m0.008s
    
    Or to make it more clear:
    
      $ elapsed_ms() {
          /usr/bin/time -f %e "$@" 2>&1 >/dev/null |
            perl -lpe '$_ *= 1000'
        }
      $ spark "$(elapsed_ms spark.old $DATA),$(elapsed_ms spark $DATA)"
      ▇▁
    peff committed Nov 15, 2011
  18. drop pointless loop

    We just reassign the data to itself in the loop, and then
    break after reading one line.
    peff committed Nov 15, 2011
  19. that was easy

    holman committed Nov 15, 2011
  20. Merge pull request #22 from benburkert/master

    Add simple roundup tests.
    holman committed Nov 15, 2011
  21. Add simple roundup tests.

    benburkert committed Nov 15, 2011
  22. Don't iteratively build output.

    This should be a bit quicker (and portable).
    JeffAbrahamson committed with holman Nov 15, 2011
  23. roundup

    holman committed Nov 15, 2011
  24. Merge pull request #18 from tombell/patch-1

    Missing "
    holman committed Nov 15, 2011
  25. Missing "

    Tom Bell committed Nov 15, 2011
  26. posix

    holman committed Nov 15, 2011
  27. Merge pull request #6 from judofyr/patch-1

    Added U+2584 to get smother ticks.
    holman committed Nov 15, 2011