Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Nov 16, 2011
  1. add full-height block

    authored
Commits on Nov 15, 2011
  1. gwern
  2. comment tests

    authored
  3. handle special case where min=max

    authored
    plus tests
  4. Use rational arithmetic instead of bc

    authored
    Use rational arithmetic throughout to avoid shelling out to bc, which
    is slow and apparently nonportable.  Instead of dealing with decimal
    numbers like 4.35, we convert 4.35 to 435 / 100 and deal with the
    integers 435 and 100.
    
    It is ridiculous, but it is a lot faster.
    
    All the tests pass now.
  5. fix expected test result for decimal test

    authored
    Since 5.5 is the minimal input value, it should be at the baseline,
    and should have the shortest possible tick, not the second-shortest.
  6. adjust expected test result

    authored
    The input data were 1,5,22,13,5
    
    Say 1 maps to a bar of height 0 and 22 to a bar of height 6.
    Then the linear mapping has that x :-> (x-1) * 2/7.
    
    So 13 :-> 24/7 = 3.43.  The test data had it displayed as a bar of
    height 4, and I changed it to a bar of height 3.
  7. cache min and max inputs

    authored
  8. fix arithmetic errors

    authored
    also use division instead of looping with trial multiplication
  9. Zach Holman

    update README

    holman authored
  10. Zach Holman

    add space tests

    holman authored
  11. Zach Holman

    Merge branch 'allow_spaced_input' of https://github.com/patricklucas/…

    holman authored
    …spark into patricklucas-allow_spaced_input
  12. Zach Holman

    (failing) test for decimals

    holman authored
  13. Patrick Lucas

    Keep individual numbers separate

    patricklucas authored
    Instead of interpreting input "1 3 2 6 8" as "13268", treat spaces
    as commas then condense.
  14. Patrick Lucas

    Change back to using 'test' for string equality

    patricklucas authored
    Minimizes this branches overall change.
  15. Patrick Lucas

    Allow spaced input

    patricklucas authored
    This allows input like "1, 2, 4, 7, 9" which is sometimes useful
    with longer lists.
  16. Merge pull request #25 from peff/22439644fb39de086482d71d36a9251966af…

    Zach Holman authored
    …fc67
    
    obvious shell cleanups
  17. Jeff King

    print sparks incrementally instead of building string

    peff authored
    This shaves a few lines from the print_ticks function. We
    use "printf" instead of "echo -n" as the former is more
    portable (although we are hopelessly tied to bash due to the
    use of arrays, anyway, so either would be fine).
  18. Jeff King

    use shell arithmetic expansion

    peff authored
    This is way faster than invoking bc repeatedly.
    
    Before:
    
      $ DATA=1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20
      $ time spark.old $DATA >/dev/null
      real    0m1.018s
      user    0m0.020s
      sys     0m0.060s
    
    After:
    
      $ time spark $DATA >/dev/null
      real    0m0.089s
      user    0m0.000s
      sys     0m0.008s
    
    Or to make it more clear:
    
      $ elapsed_ms() {
          /usr/bin/time -f %e "$@" 2>&1 >/dev/null |
            perl -lpe '$_ *= 1000'
        }
      $ spark "$(elapsed_ms spark.old $DATA),$(elapsed_ms spark $DATA)"
      ▇▁
  19. Jeff King

    drop pointless loop

    peff authored
    We just reassign the data to itself in the loop, and then
    break after reading one line.
  20. Zach Holman

    that was easy

    holman authored
  21. Merge pull request #22 from benburkert/master

    Zach Holman authored
    Add simple roundup tests.
  22. Ben Burkert

    Add simple roundup tests.

    benburkert authored
  23. Jeff Abrahamson Zach Holman

    Don't iteratively build output.

    JeffAbrahamson authored holman committed
    This should be a bit quicker (and portable).
  24. Zach Holman

    roundup

    holman authored
  25. Zach Holman
  26. Merge pull request #18 from tombell/patch-1

    Zach Holman authored
    Missing "
  27. Tom Bell

    Missing "

    tombell authored
  28. Zach Holman

    posix

    holman authored
  29. Merge pull request #6 from judofyr/patch-1

    Zach Holman authored
    Added U+2584 to get smother ticks.
Something went wrong with that request. Please try again.