Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow string mac address in constructor #241

Merged
merged 1 commit into from May 18, 2019

Conversation

Projects
None yet
2 participants
@gpenverne
Copy link
Contributor

commented May 10, 2019

Not really a fix, but I lost a lot of time before understand that we have to pass the mac adress in byteArray...

To reproduce case:

import broadlink
device = broadlink.rm(("123.123.123.123", 80), "XX:XX:XX:XX:XX", 'RM2')

And error is trigered:
TypeError TypeError: an integer is required

(But this trouble doesn't apper in the python2 version)

I found an issue about this (an old one...): #8

@gpenverne gpenverne marked this pull request as ready for review May 10, 2019

@mjg59 mjg59 merged commit 77f11c8 into mjg59:master May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.