Skip to content
This repository has been archived by the owner on Mar 4, 2019. It is now read-only.

exclude fakeLocalStorageAndDocument #80

Open
jorda0mega opened this issue Dec 23, 2016 · 3 comments
Open

exclude fakeLocalStorageAndDocument #80

jorda0mega opened this issue Dec 23, 2016 · 3 comments

Comments

@jorda0mega
Copy link
Contributor

the function fakeLocalStorageAndDocument

function fakeLocalStorageAndDocument() {

is interfering with firebase's connection to the server. Is there a way to exclude this from the build?

@pesterhazy
Copy link
Collaborator

Do you know which part of the shim causes these issues?

  • window.localStorage
  • window.document
  • window.location ?

What kind of issue are you seeing?

I'm not sure if these shims are still needed for current versions of boot-reload etc., so it's clearly a good idea to investigate.

@pesterhazy
Copy link
Collaborator

After looking into this, it looks like boot-reload needs a small patch to work without window.location being present. I've submitted a PR:

adzerk-oss/boot-reload#110

Not seeing any other issues removing fakeLocalStorageAndDocument altogether

@jorda0mega
Copy link
Contributor Author

thanks :) basically all firebase storage remains local, never makes it to the firebase console. Once I took this function out I was able to access the firebase server and also save data correctly. I don't know if that makes sense?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants