New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing <tbody> tags after <table> in mjml-hero, mjml-button and mjml-social components #2111
Conversation
I think I messed PR a bit, I found that README.md has Please let me know if this url change in readme is not needed, I will resubmit PR then. (I forget to create new branch in my fork for this PR) |
This was a reference to the old 3.X branch here https://github.com/mjmlio/mjml/tree/3.3.x#contribute I think you can remove it too |
@iRyusa should I revert change in last commit? |
You can juste remove the link and mention i'll squash it |
@iRyusa removed contribution reference in readme. |
thanks for this PR 👍 |
@kmcb777 100% would love to see it in v5 (I will need to update some of my templates too). |
Even if it breaks a bit the DOM I think we should merge this in 4.10 as it's way better for accessibility cc @Pharmasolin can you resolve the conflict so we get this merged ? |
@iRyusa resolved the conflict, but please check if everything is ok before merging this branch to master. For example it has change to readme.md as well. |
Looks good to me this section no longer exist in the readme anyway :D |
I noticed that mjml-hero, mjml-button and mjml-social components didn't have
<tbody>
and</tbody>
, this might add confusion for developers who might want to usemj-html-attributes
component and css child combinator>
.