Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ts type improvements, simplify intercept method name #25

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@JounQin
Copy link
Member

JounQin commented Aug 15, 2019

No description provided.

@JounQin JounQin requested a review from foreleven Aug 15, 2019
@JounQin JounQin self-assigned this Aug 15, 2019
@JounQin JounQin added the refactor label Aug 15, 2019
@JounQin JounQin added this to In progress in RoadMap via automation Aug 15, 2019
@JounQin JounQin added this to the 1.0 milestone Aug 15, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #25 into master will decrease coverage by 10.25%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #25       +/-   ##
===========================================
- Coverage    81.1%   70.85%   -10.26%     
===========================================
  Files          21       21               
  Lines         254      247        -7     
  Branches       26       24        -2     
===========================================
- Hits          206      175       -31     
- Misses         47       72       +25     
+ Partials        1        0        -1
Impacted Files Coverage Δ
src/context/StatedBeanProvider.tsx 100% <ø> (ø) ⬆️
src/core/StatedBeanContainer.ts 96.42% <100%> (+3.32%) ⬆️
src/metadata/index.ts 100% <100%> (ø) ⬆️
src/core/StatedBeanFactory.ts 100% <100%> (ø) ⬆️
src/hooks/useContainer.ts 47.22% <33.33%> (-31.73%) ⬇️
src/decorator/PostProvided.ts 50% <33.33%> (+10%) ⬆️
src/core/EffectContext.ts 41.66% <36.36%> (-32.25%) ⬇️
src/core/StatedBeanApplication.ts 35% <44.44%> (-25%) ⬇️
src/hooks/useStatedBean.ts 80% <83.33%> (+10.43%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a87bf7...8b42bbb. Read the comment docs.

@foreleven foreleven merged commit 87db361 into master Aug 15, 2019
5 of 7 checks passed
5 of 7 checks passed
codecov/patch 55.55% of diff hit (target 81.1%)
Details
codecov/project 70.85% (-10.26%) compared to 2a87bf7
Details
Build Size Change: -764B (-0.43%) Total: 171.89KB
Details
Commit Deployment Deployment ready
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Type Coverage Change: +2.50% Total: 97.04% New untyped symbols: 2
Details
RoadMap automation moved this from In progress to Done Aug 15, 2019
@JounQin JounQin deleted the develop branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
RoadMap
  
Done
2 participants
You can’t perform that action at this time.