New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix find_special_folder #363

Merged
merged 1 commit into from Sep 19, 2018

Conversation

2 participants
@Unpublished
Contributor

Unpublished commented Sep 18, 2018

No description provided.

@NicolasLM

This comment has been minimized.

Show comment
Hide comment
@NicolasLM

NicolasLM Sep 18, 2018

Collaborator

Hi,
Thank you for the patch. It's great that you added a test case, however would you mind describing briefly the problem you're fixing in the commit message? You can amend your commit. Thanks!

Collaborator

NicolasLM commented Sep 18, 2018

Hi,
Thank you for the patch. It's great that you added a test case, however would you mind describing briefly the problem you're fixing in the commit message? You can amend your commit. Thanks!

@Unpublished

This comment has been minimized.

Show comment
Hide comment
@Unpublished

Unpublished Sep 18, 2018

Contributor

Hey,
sorry for the incomplete PR, I just wanted to quickly fix it and share it. The problem is that previous implementation of find_special_folder expects the special flag at the second position, however that's not true for all servers. I fixed that by scanning through all flags.

I'll amend the message tomorrow.

Contributor

Unpublished commented Sep 18, 2018

Hey,
sorry for the incomplete PR, I just wanted to quickly fix it and share it. The problem is that previous implementation of find_special_folder expects the special flag at the second position, however that's not true for all servers. I fixed that by scanning through all flags.

I'll amend the message tomorrow.

find_special_folder: search for folder_flag in all flags
not all special flags are stored at the second position

Additionally add support for a single flag
@Unpublished

This comment has been minimized.

Show comment
Hide comment
@Unpublished

Unpublished Sep 19, 2018

Contributor

While updating I noticed another theoretical cornercase (only a single flag), let me know if you still need additional information.

Contributor

Unpublished commented Sep 19, 2018

While updating I noticed another theoretical cornercase (only a single flag), let me know if you still need additional information.

@NicolasLM

This comment has been minimized.

Show comment
Hide comment
@NicolasLM

NicolasLM Sep 19, 2018

Collaborator

Great, thank you!

Collaborator

NicolasLM commented Sep 19, 2018

Great, thank you!

@NicolasLM NicolasLM merged commit 580dc67 into mjs:master Sep 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Unpublished Unpublished deleted the Unpublished:find_special_folder_fix branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment