From 6b55b033f374c5a901c23bdb456a98b1bc50dc29 Mon Sep 17 00:00:00 2001 From: Matthew Kay Date: Sat, 2 Mar 2024 13:21:57 -0600 Subject: [PATCH] update cran comments --- cran-comments.md | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 4b6e39eb..2857aa87 100755 --- a/cran-comments.md +++ b/cran-comments.md @@ -23,13 +23,7 @@ This release addresses some minor issues introduced by the recent ggplot2 3.5.0 ## revdepcheck results -We checked 28 reverse dependencies (26 from CRAN + 2 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. +We checked 29 reverse dependencies (27 from CRAN + 2 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. - * We saw 1 new problems + * We saw 0 new problems * We failed to check 0 packages - -Issues with CRAN packages are summarised below. - -### New problems - -* fabletools currently fails in one example and two tests due to a change in some internal ggdist data structures (related to colour ramps) that fabletools made use of. The details of those data structures have been changed in this release (causing the error), but this change was done in order to solidify and improve ggdist's public-facing API for colour ramps. As part of that change, the new `ggdist::ramp_colours()` function is now exported that fabletools can use. A PR has been submitted to fabletools to make this change: https://github.com/tidyverts/fabletools/pull/397