Commits on May 12, 2014
  1. @senny
  2. @senny
  3. @senny

    Merge pull request #13334 from gregolsen/postgresql_infinity

    pg, fix Infinity and NaN values conversion.
    
    Closes #13334.
    
    * rebased
    * removed guard
    * inlined guard into case statement
    senny committed May 12, 2014
  4. @gregolsen @senny

    pg, fix Infinity and NaN values conversion.

    Before this patch `Infinity`, `-Infinity` and `Nan` were read as `0`.
    gregolsen committed with senny Dec 18, 2013
  5. @senny

    Merge pull request #10505 from patricksrobertson/bigserial_id_not_ide…

    …ntifying_pk
    
    Handle other pk types in PostgreSQL gracefully.
    
    Closes #10505.
    
    - rebased
    - test slightly modified
    senny committed May 12, 2014
  6. @patricksrobertson @senny

    Handle other pk types in PostgreSQL gracefully.

    In #10410 it was noted that you can no longer create PK's with the
    type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly
    because the newer adapter is checking for column type with the
    id column instead of just letting it pass through like it did
    before.
    
    Side effects:
    You may just create a PK column of a type that you really don't
    want to be your PK. As far as I can tell this was allowed in 3.2.X
    and perhaps an exception should be raised if you try and do
    something extremely dumb.
    patricksrobertson committed with senny May 7, 2013
  7. @senny

    Merge pull request #14999 from yahonda/modify_bind_variable_name

    Modify assert conditions not to be affected
    by each database bind variable naming conventions
    
    Closes #14999.
    senny committed May 12, 2014
  8. @yahonda @senny

    Modify assert conditions not to be affected

    by each database bind variable naming conventions
    yahonda committed with senny May 7, 2014
  9. @rafaelfranca

    Merge pull request #15060 from tgxworld/remove_unnecessary_tests_method

    Remove redundant tests method.
    rafaelfranca committed May 12, 2014
  10. @guilleiguaran

    Update attribute_methods.rb

    Improve documentation
    guilleiguaran committed May 11, 2014
  11. @guilleiguaran

    Merge pull request #15063 from cbeer/correct-attribute_present-docs

    correcting method documentation [ci skip]
    guilleiguaran committed May 11, 2014
  12. @cbeer
Commits on May 11, 2014
  1. @tgxworld

    Remove redundant tests method.

    tgxworld committed May 11, 2014
  2. @carlosantoniodasilva

    Merge pull request #10662 from take/change-test-name-for-ActiveRecord…

    …--Validations#valid-
    
    Refactor AR's validations_test.rb
    carlosantoniodasilva committed May 11, 2014
  3. @robin850

    Merge pull request #15059 from marcioj/patch-1

    Replace :base with :in [ci skip]
    robin850 committed May 11, 2014
  4. @marcioj

    Replace :base with :in [ci skip]

    marcioj committed May 11, 2014
  5. @pixeltrix

    Tidy up implementation of #15010

    pixeltrix committed May 11, 2014
  6. @ucarion @pixeltrix

    Make TimeZone#parse behave more like Time#parse.

    Namely, if the mday is omitted but any other upper components are, then instead
    of supplying the mday from the current time, it defaults to 1.
    ucarion committed with pixeltrix May 7, 2014
  7. @senny

    docs, make `ActionNotFound` public API. [ci skip]

    This is a follow up to #15058.
    
    This exception is regularly raised during development. This means it will enter
    the user realm. We should provide an API page to show that this exception is public API.
    
    /cc @schneems
    senny committed May 11, 2014
  8. @schneems

    Merge pull request #15058 from Gaurav2728/gaurav-doc_message

    adding complete message in documentation [ci skip]
    schneems committed May 11, 2014
  9. @Gaurav2728
  10. @pixeltrix
  11. @pixeltrix

    Always use the provided port for protocol relative urls

    There may be situations where you need to tunnel SSL connections over
    port 80 so we shouldn't remove it if it has been explicitly provided.
    pixeltrix committed May 11, 2014
  12. @guiocavalcanti @pixeltrix
  13. @senny
Commits on May 10, 2014
  1. @senny
  2. @rafaelfranca

    Merge pull request #15056 from josemarluedke/single-quotes-on-plugin-…

    …gemfile
    
    Change Gemfile’s double quotation marks in plugin generator
    rafaelfranca committed May 10, 2014
  3. @josemarluedke

    Change Gemfile’s double quotes in plugin generator

    Since the generated application’s Gemfile is using single quotation marks, it
    seems fair to use it on plugin’s Gemfile as well.
    josemarluedke committed May 10, 2014
  4. @rafaelfranca

    Merge pull request #15054 from mechanicles/documentation-consistency

    Keep method's description/documentation consistent [ci skip]
    rafaelfranca committed May 10, 2014
  5. @mechanicles
  6. @tenderlove
  7. @vijaydev
  8. @vijaydev
  9. @vijaydev

    copy edits [ci skip]

    vijaydev committed May 10, 2014
  10. @senny

    deprecate, join, preload, eager load of instance dependent associations.

    Closes #15024.
    
    These operations happen before instances are created.
    The current behavior is misleading and can result in broken behavior.
    senny committed May 10, 2014