Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Apache POI 4.0 #78

Closed
mjul opened this issue Oct 14, 2018 · 2 comments
Closed

Upgrade to Apache POI 4.0 #78

mjul opened this issue Oct 14, 2018 · 2 comments

Comments

@mjul
Copy link
Owner

mjul commented Oct 14, 2018

The Apache POI project used by Docjure has released version 4.0.0.
Docjure should be upgraded from the 3.x series to use the latest version.
Read about Apache POI here: http://poi.apache.org

@manuelherzog
Copy link
Contributor

manuelherzog commented Mar 8, 2019

Hey,

right now i'm doing the migration, as i need the newer version for other POI tasks and libs.

I'm getting to multiple problems before i could start, lein test did not run because the Classloader was not found. I updated pomegranate and then get the error that there is no writeable Classloader anymore. Then i removed that one test that was failing because it can't add the test-data to the classpath.

I upgraded to POI 4.0.1 and it works quite easily.

But, now i get the exception "Truncated ZIP file" on one test only. Rolled back and noticed that the stream that was written to was not closed properly.

Sending you the pull request with 3 commits, if you want to fix the two problems not directly attached to the migration in another way

Best
Manuel
PR #81

@mjul
Copy link
Owner Author

mjul commented Jun 26, 2020

Thanks for this and the PR. It has already been merged, so I am closing this.

@mjul mjul closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants