New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new code for hiding devtools #55

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
2 participants
@mkaply
Owner

mkaply commented Mar 16, 2017

No description provided.

@mkaply mkaply merged commit f7d78e3 into master Mar 23, 2017

@mkaply mkaply deleted the ff52_devtools branch Mar 23, 2017

@kaihendry

This comment has been minimized.

Show comment
Hide comment
@kaihendry

kaihendry Mar 25, 2017

I attempted to grab the relevant bits and integrate it but F12 still seems to work: Webconverger/webconverger-addon@f390dc4

Tbh I have no idea how to debug if the code is even running.

kaihendry commented Mar 25, 2017

I attempted to grab the relevant bits and integrate it but F12 still seems to work: Webconverger/webconverger-addon@f390dc4

Tbh I have no idea how to debug if the code is even running.

@mkaply

This comment has been minimized.

Show comment
Hide comment
@mkaply

mkaply Mar 31, 2017

Owner

That's odd. in my testing, It removed F12 as well. Best way to debug is to throw in some "Components.utils.reportError('foo')" and use the Javascript console. I'll see what I can figure out.

Owner

mkaply commented Mar 31, 2017

That's odd. in my testing, It removed F12 as well. Best way to debug is to throw in some "Components.utils.reportError('foo')" and use the Javascript console. I'll see what I can figure out.

@kaihendry

This comment has been minimized.

Show comment
Hide comment
@kaihendry

kaihendry Apr 2, 2017

Wonder if the old let console = (Cu.import("resource://gre/modules/devtools/Console.jsm", {})).console trick works still? Still my development iteration is maddening ... https://www.youtube.com/watch?v=aBIqpEFmfUI

kaihendry commented Apr 2, 2017

Wonder if the old let console = (Cu.import("resource://gre/modules/devtools/Console.jsm", {})).console trick works still? Still my development iteration is maddening ... https://www.youtube.com/watch?v=aBIqpEFmfUI

@kaihendry

This comment has been minimized.

Show comment
Hide comment
@kaihendry

kaihendry commented Apr 2, 2017

Oh btw, here is your work in Webconverger/webconverger-addon@cbad324

@mkaply

This comment has been minimized.

Show comment
Hide comment
@mkaply

mkaply Apr 12, 2017

Owner

No, your console trick won't work. The devtools JS console is completely different on Firefox 52. And yes, I agree it's maddening.

Owner

mkaply commented Apr 12, 2017

No, your console trick won't work. The devtools JS console is completely different on Firefox 52. And yes, I agree it's maddening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment