Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle default values of None #41

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Correctly handle default values of None #41

merged 1 commit into from
Nov 19, 2021

Conversation

yuyu2172
Copy link
Contributor

@yuyu2172 yuyu2172 commented Aug 4, 2021

Options with None as default value are not handled correctly.
This PR fixes the issue.

e.g.

@click.option("-m", "--message", required=False, default=None)

Before

Screenshot from 2021-08-05 08-47-51

After

Screenshot from 2021-08-05 08-46-08

@yuyu2172 yuyu2172 changed the title correctly handle not required option with default value None correctly handle default value None Aug 4, 2021
@ofek ofek changed the title correctly handle default value None Correctly handle default values of None Nov 19, 2021
ofek
ofek approved these changes Nov 19, 2021
View reviewed changes
Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ofek ofek merged commit be07463 into mkdocs:master Nov 19, 2021
@yuyu2172 yuyu2172 deleted the none-default-not-required branch November 21, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuyu2172 @ofek