New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all deprecated code in prep for 1.0 #1168

Closed
waylan opened this Issue Mar 15, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@waylan
Member

waylan commented Mar 15, 2017

Just a reminder so we don't forget about it. There are a bunch of "TODO" comments in the code marking sections that need removed etc.

$ grep -n -r "TODO" *
mkdocs/commands/build.py:90:        # TODO: remove the rest in 1.0 as they are deprecated
mkdocs/commands/build.py:124:    # TODO: remove the rest in version 1.0 as they are deprecated
mkdocs/commands/build.py:138:        # TODO: remove the rest in version 1.0 as they are deprecated
mkdocs/commands/build.py:204:            # TODO: Remove this in version 1.0
mkdocs/commands/build.py:259:    # TODO: remove DeprecationContext in v1.0 when all deprecated vars have been removed
mkdocs/commands/build.py:296:    # TODO: end remove DeprecationContext
mkdocs/config/config_options.py:278:    TODO: This could probably be improved and/or moved from here. It's a tad
mkdocs/config/config_options.py:428:        # TODO: Remove in 1.0
mkdocs/config/config_options.py:472:        # TODO: delete deprecated `NumPages` class in version 1.0
mkdocs/config/defaults.py:36:    # TODO: remove this in version 1.0
mkdocs/config/defaults.py:96:    # TODO: delete deprecated `include_nav` and `include_next_previous` in version 1.0
mkdocs/legacy.py:44:    TODO: Remove in 1.0
mkdocs/tests/integration.py:12:TODOs
mkdocs/tests/legacy_tests.py:9:    # TODO: Remove in 1.0
mkdocs/utils/__init__.py:73:        # TODO: Remove this when external calls are properly cleaning up file
mkdocs/utils/__init__.py:332:    # TODO: Fix this, this is a hack. Relative urls  are not being calculated

Most of those are relevant here.

@waylan waylan added the Deprecation label Mar 15, 2017

@waylan waylan added this to the 1.0.0 milestone Mar 15, 2017

@waylan waylan self-assigned this Mar 15, 2017

waylan added a commit to waylan/mkdocs that referenced this issue Mar 16, 2017

waylan added a commit to waylan/mkdocs that referenced this issue Mar 16, 2017

waylan added a commit to waylan/mkdocs that referenced this issue Mar 16, 2017

waylan added a commit to waylan/mkdocs that referenced this issue Mar 16, 2017

waylan added a commit to waylan/mkdocs that referenced this issue Mar 16, 2017

@waylan

This comment has been minimized.

Member

waylan commented Mar 16, 2017

We also have the mkdocs-bootstrap and mkdocs-bootswatch themes for which we raise a special error if they are not installed. Probably want to remove that. Also check that we never install them anywhere (perhaps in tests).

waylan added a commit to waylan/mkdocs that referenced this issue Mar 16, 2017

waylan added a commit to waylan/mkdocs that referenced this issue Mar 16, 2017

waylan added a commit that referenced this issue Mar 16, 2017

waylan added a commit that referenced this issue Mar 16, 2017

waylan added a commit that referenced this issue Mar 16, 2017

waylan added a commit that referenced this issue Mar 16, 2017

@waylan waylan closed this Mar 16, 2017

waylan added a commit to waylan/mkdocs that referenced this issue Sep 28, 2017

waylan added a commit to waylan/mkdocs that referenced this issue Sep 28, 2017

waylan added a commit to waylan/mkdocs that referenced this issue Sep 28, 2017

waylan added a commit to waylan/mkdocs that referenced this issue Sep 28, 2017

waylan added a commit that referenced this issue Oct 1, 2017

waylan added a commit that referenced this issue Oct 1, 2017

waylan added a commit that referenced this issue Oct 1, 2017

waylan added a commit that referenced this issue Oct 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment