Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search modal should close when result selected. #1527

Closed
waylan opened this issue Jul 2, 2018 · 0 comments
Closed

Search modal should close when result selected. #1527

waylan opened this issue Jul 2, 2018 · 0 comments

Comments

@waylan
Copy link
Member

@waylan waylan commented Jul 2, 2018

When using the search modal (popup) to display search results (as we do in the MkDocs theme), the modal does not close when a result is selected. This is fine when the result is on a different page as the browser requests the new page, which is displayed without the modal visible. However, if the result is on the same page, the modal remains open and hides the page. For example, view the homepage of MkDocs' documentation (use the dev serve on the master branch to get the newly refactored search), open the search modal. and search for installation. Select one of the results on the home page (for example "Installation" with the link being #installation). If you look closely you can see the page scroll behind the modal, but the modal does not close. If you close the modal manually, then you can see that the page did properly scroll to the Installation heading. However, the modal should have closed without the extra step.

@waylan waylan added this to the 1.0.0 milestone Jul 2, 2018
waylan added a commit to waylan/mkdocs that referenced this issue Jul 4, 2018
@waylan waylan closed this in #1532 Jul 4, 2018
waylan added a commit that referenced this issue Jul 4, 2018
Fixes #1527.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant