Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong language codes #1729

Closed
cocoatomo opened this issue Jan 21, 2019 · 11 comments
Closed

Wrong language codes #1729

cocoatomo opened this issue Jan 21, 2019 · 11 comments

Comments

@cocoatomo
Copy link

cocoatomo commented Jan 21, 2019

The language code list at lang section contains two errors.

du: Dutch should be nl: Dutch and jp: Japanese should be ja: Japanese.

ref. https://www.loc.gov/standards/iso639-2/php/English_list.php

@waylan
Copy link
Member

waylan commented Jan 22, 2019

The abbreviations we use are the abbreviations supported by Lunr Languages. As it turns out, Lunr Language treats ja and jp as aliases, so we could change that (in the documentation; either will work in practice). However, they use du, but not nl. There is nothing we can do to change that. I would suggest reporting the issue upstream.

@trel
Copy link
Contributor

trel commented Jan 22, 2019

filed nearly a year ago - MihaiValentin/lunr-languages#43

@mitya57
Copy link
Contributor

mitya57 commented Jan 22, 2019

FWIW lunr-languages looks abandoned, last commit was 1.5 years ago.

@cocoatomo
Copy link
Author

cocoatomo commented Jan 22, 2019

Thank you for your comments. I understand where language names are come from.
I will take action on lunr-languages repository.

@cocoatomo
Copy link
Author

cocoatomo commented Jan 22, 2019

I submitted the PR to lunr-languages.
MihaiValentin/lunr-languages#50

@cocoatomo
Copy link
Author

cocoatomo commented Feb 23, 2019

My PR is closed, but MihaiValentin created more appropreate diff and commited it to resolve the issue.

@waylan
Copy link
Member

waylan commented Feb 23, 2019

Thanks for the update. For reference, the relevant change was made in
MihaiValentin/lunr-languages@b38058e1c, which appears to be included in the now released version 1.1.0 of lunr-languages. A PR is welcome here to update MkDocs to use the updated version along with the newly corrected language code.

@waylan waylan added the Bug label Feb 23, 2019
@waylan waylan added this to the 1.1 milestone Feb 23, 2019
@backtrackbaba
Copy link

backtrackbaba commented Jun 11, 2019

@waylan If nobody has taken this up I'd like to give this a try!

@jimporter
Copy link
Contributor

jimporter commented Feb 7, 2020

Assuming this is still open by the time I finish fixing #770, I'm going to take this and fix it so we can close out the 1.1 milestone. If someone else wants to work on this though, feel free to take it!

@waylan
Copy link
Member

waylan commented Feb 17, 2020

@jimporter feel free to take this. Then we can release version 1.1.

@ofek
Copy link
Contributor

ofek commented Feb 20, 2020

I'm very excited for the next release!

jimporter added a commit to jimporter/mkdocs that referenced this issue Feb 21, 2020
This renames the Dutch language code to `nl`, the Japanese code to `ja`, and
adds support for Arabic (`ar`) and Vietnamese (`vi`).
jimporter added a commit to jimporter/mkdocs that referenced this issue Feb 21, 2020
This renames the Dutch language code to `nl`, the Japanese code to `ja`, and
adds support for Arabic (`ar`) and Vietnamese (`vi`).
@waylan waylan closed this as completed in a7c349c Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants