-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong language codes #1729
Comments
The abbreviations we use are the abbreviations supported by Lunr Languages. As it turns out, Lunr Language treats |
filed nearly a year ago - MihaiValentin/lunr-languages#43 |
FWIW lunr-languages looks abandoned, last commit was 1.5 years ago. |
Thank you for your comments. I understand where language names are come from. |
I submitted the PR to lunr-languages. |
My PR is closed, but MihaiValentin created more appropreate diff and commited it to resolve the issue. |
Thanks for the update. For reference, the relevant change was made in |
@waylan If nobody has taken this up I'd like to give this a try! |
Assuming this is still open by the time I finish fixing #770, I'm going to take this and fix it so we can close out the 1.1 milestone. If someone else wants to work on this though, feel free to take it! |
@jimporter feel free to take this. Then we can release version 1.1. |
I'm very excited for the next release! |
This renames the Dutch language code to `nl`, the Japanese code to `ja`, and adds support for Arabic (`ar`) and Vietnamese (`vi`).
This renames the Dutch language code to `nl`, the Japanese code to `ja`, and adds support for Arabic (`ar`) and Vietnamese (`vi`).
The language code list at lang section contains two errors.
du: Dutch
should benl: Dutch
andjp: Japanese
should beja: Japanese
.ref. https://www.loc.gov/standards/iso639-2/php/English_list.php
The text was updated successfully, but these errors were encountered: