Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken sitemap.xml with external link in nav #1742

Closed
brandongc opened this issue Feb 8, 2019 · 1 comment
Closed

broken sitemap.xml with external link in nav #1742

brandongc opened this issue Feb 8, 2019 · 1 comment

Comments

@brandongc
Copy link
Contributor

@brandongc brandongc commented Feb 8, 2019

A mkdocs.yml like:

nav:
    - Home: index.md
    - Test: https://www.example.com
    - User Guide:
        - Writing Your Docs: user-guide/writing-your-docs.md

results in a sitemap.xml that google search console throws errors for:

    <url>
     <loc></loc>

     <changefreq>daily</changefreq>
    </url>
@waylan
Copy link
Member

@waylan waylan commented Feb 8, 2019

I hadn't thought about that. I suppose the sitemap template should skip external links. Of course, a PR is welcome. Shouldn't be a difficult fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants