Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Analytics works on the MkDocs theme only #333

Closed
EdyJ opened this issue Jan 19, 2015 · 0 comments · Fixed by #338
Closed

Google Analytics works on the MkDocs theme only #333

EdyJ opened this issue Jan 19, 2015 · 0 comments · Fixed by #338
Labels
Bug
Milestone
0.12.0

Comments

@EdyJ
Copy link

EdyJ commented Jan 19, 2015

The Google Analytics code is actually implemented on the MkDocs theme only (file base.html). The option google_analytics is ignored on any other theme.

In addition, looks like the second parameter of the google_analytics setting is no longer necessary. The latest code generated by Google Analytics uses 'auto' instead of the domain.
@d0ugal d0ugal added the Bug label Jan 20, 2015
@d0ugal d0ugal added this to the 1.0.0 milestone Jan 20, 2015
@dustinfarris dustinfarris mentioned this issue Feb 1, 2015
Merged
@d0ugal d0ugal modified the milestones: 0.12.0, 1.0.0 Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Add Google Analytics block to all themes dustinfarris/mkdocs
2 participants
@d0ugal @EdyJ