Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the JSON command #481

Closed
d0ugal opened this issue Apr 27, 2015 · 3 comments
Closed

Deprecate the JSON command #481

d0ugal opened this issue Apr 27, 2015 · 3 comments
Labels
Milestone

Comments

@d0ugal
Copy link
Member

@d0ugal d0ugal commented Apr 27, 2015

Now that #457 has landed we should have people use the JSON it creates and remove the JSON command which is otherwise a bit weird.

Add a warning for 0.13
Louder warning in 0.14
Remove in 1.0

@d0ugal d0ugal added this to the 0.13.0 milestone Apr 27, 2015
@d0ugal d0ugal added the Deprecation label Apr 27, 2015
@d0ugal
Copy link
Member Author

@d0ugal d0ugal commented Apr 27, 2015

This will involve some work on the ReadTheDocs side - I wont remove this fully until we can get them transitioned over somehow.

d0ugal added a commit to d0ugal/mkdocs that referenced this issue Apr 27, 2015
d0ugal added a commit to d0ugal/mkdocs that referenced this issue Apr 28, 2015
@d0ugal d0ugal closed this in 075410d May 1, 2015
@d0ugal d0ugal reopened this May 1, 2015
@d0ugal
Copy link
Member Author

@d0ugal d0ugal commented May 1, 2015

This isn't actually fixed by 075410d. It'll be fixed when the command is fully removed.

@d0ugal d0ugal modified the milestones: 0.13.0, 0.14.0 May 1, 2015
@d0ugal
Copy link
Member Author

@d0ugal d0ugal commented May 1, 2015

Need to revisit this for 0.14.0

@d0ugal d0ugal modified the milestones: 0.14.0, 0.15.0 Jun 4, 2015
@d0ugal d0ugal modified the milestone: 0.15.0 Jan 14, 2016
waylan added a commit to waylan/mkdocs that referenced this issue Aug 8, 2016
Previously we only tested that the CLI commands called the approiate function.
Now we also test that the correct options are passed. A few recently
introduced bugs were caught while building these tests (fixed in the
previous couple commits).

Left off tests for the `json` command as it is being deprecated (see mkdocs#481).

Closes mkdocs#1016 and mkdocs#1014.
waylan added a commit to waylan/mkdocs that referenced this issue Aug 8, 2016
Previously we only tested that the CLI commands called the approiate function.
Now we also test that the correct options are passed. A few recently
introduced bugs were caught while building these tests (fixed in the
previous couple commits).

Left off tests for the `json` command as it is being deprecated (see mkdocs#481).

Closes mkdocs#1016 and mkdocs#1014.
waylan added a commit to waylan/mkdocs that referenced this issue Aug 8, 2016
Previously we only tested that the CLI commands called the approiate function.
Now we also test that the correct options are passed. A few recently
introduced bugs were caught while building these tests (fixed in the
previous couple commits).

Left off tests for the `json` command as it is being deprecated (see mkdocs#481).

Closes mkdocs#1016 and mkdocs#1014.
@waylan waylan added this to the 1.0.0 milestone Dec 2, 2016
waylan added a commit to waylan/mkdocs that referenced this issue Mar 16, 2017
waylan added a commit to waylan/mkdocs that referenced this issue Mar 16, 2017
waylan added a commit that referenced this issue Mar 16, 2017
Closes #481.
@waylan waylan closed this Mar 16, 2017
waylan added a commit to waylan/mkdocs that referenced this issue Sep 28, 2017
waylan added a commit that referenced this issue Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants