Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright not displayed with readthedocs theme #568

Closed
timorjim opened this issue May 28, 2015 · 5 comments
Closed

Copyright not displayed with readthedocs theme #568

timorjim opened this issue May 28, 2015 · 5 comments
Labels
Milestone

Comments

@timorjim
Copy link

@timorjim timorjim commented May 28, 2015

It seems the copyright footer is not displayed when using the readthedocs theme. I have tried a few different themes and it then appears as expected.

I just noticed #554, perhaps this will fix it?

Cheers

@d0ugal
Copy link
Member

@d0ugal d0ugal commented May 28, 2015

@timbarber Is this when you host it on ReadTheDocs or when you build it locally? If it is when you host it on ReadTheDocs, then, yes, #554 should fix it.

@timorjim
Copy link
Author

@timorjim timorjim commented May 28, 2015

@d0ugal, this is happening locally when running 'mkdocs serve'.

@d0ugal d0ugal added Bug and removed Needs information labels May 28, 2015
@d0ugal d0ugal added this to the 0.14.0 milestone May 28, 2015
@d0ugal
Copy link
Member

@d0ugal d0ugal commented May 28, 2015

@timbarber I just checked, it seems it was never added to the ReadTheDocs theme. We should do that.

@d0ugal
Copy link
Member

@d0ugal d0ugal commented May 28, 2015

It should just be a case of adding something like this:

        {% if copyright %}
            <center>{{ copyright }}</center>
        {% endif %}

To https://github.com/mkdocs/mkdocs/blob/master/mkdocs/themes/readthedocs/base.html

@d0ugal d0ugal modified the milestone: 0.14.0 Jun 2, 2015
@d0ugal d0ugal added Enhancement and removed Bug labels Jun 3, 2015
@d0ugal
Copy link
Member

@d0ugal d0ugal commented Jun 4, 2015

Fixed by #584

@d0ugal d0ugal closed this Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.