New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPEL7 #763
Comments
Good question. I think 4.0 was just the most recent version when I wrote the CLI interface and I didn't test against older versions.
I don't really want the serve command to require extra install steps. I wasn't aware that rpms would use the setup.py at all, is there a way you can skip those requirements during packaging? |
As I recall, any earlier versions of livereload will break MkDocs on some platforms (see #518 for example) and the 2.3.2 version of livereload requires at least version 4.1 of Tornado. |
That is understandable.
The RPM build process calls
Can you take a peek at the 4.0 changelog and see if any of those changes sound critical to mkdocs? If not, lowering the minimum version in |
Well in the epel7 packaging I am droping the missing requieres in the setup.py file (look at lines 53 and 54) so I can drop the click depency so pkg_reources do not fail if there is not the explicit version available. http://pkgs.fedoraproject.org/cgit/mkdocs.git/tree/mkdocs.spec?h=epel7 Anyway the new and build comands should work fine and I understand than there is no a --no-liveread option to pase to the serve comando should mkdocs can be fully funtional in epel7 after that. |
@williamjmorenor A patch for setup.py would be safer than sed'ing out specific lines, as those line numbers may change in future releases. I can add the patch if you would like to add me as a co-maintainer, FAS username is "carlgeorge". |
This build do not requieres is specific tornado, livereload and click versions https://koji.fedoraproject.org/koji/buildinfo?buildID=701080 |
It looks like this was resolved. I don't think we needed to do anything in the end. |
@d0ugal Would it be possible to lower the minimum version of click to version 3.3? Here are the features added between 3.3 (current EPEL7 version) and 4.0 (your specified minimum version).
If none of these are essential, there shouldn't be an issue lowering the minimum version requirement of click. |
I did a quick review (a couple minutes) of the list of features added and nothing jumped out at me as a problem. But the only way to be sure is to test it. As a start, you could change the required version (also here) on a local copy and run the tests (with tox - see the docs). However, the tests of the click commands use mock objects for some stuff, so some manual testing would be necessary as well. |
Thanks! |
Currently
setup.py
specifies that click must be at least version 4.0. I'm currently working with the Fedora package maintainer to get this added to EPEL for RHEL7. There are few dependency problems we are noticing.tornado>=4.1
andlivereload>=2.3.2
In RHEL7 tornado is stuck at
2.2.1
. livereload isn't packaged for RHEL7 at all (yet). As far as I can tell, these are only needed for theserve
subcommand. Would you consider changing these requirements to extras?click>=4.0
As a test, I manually edited the requires.txt in my egg-info directory after installing, and mkdocs appears to work just fine with click
3.3
. Are there any known or planned features that actually require click4.0
?The text was updated successfully, but these errors were encountered: