Python3

[sloria]

Fixes a number of Python 3 incompatiblities (resolves #51 ). This patch tests against py26, py27, py33, and py34. All tests are currently passing on tox.

[lovelydinosaur]

Looks good!

[lovelydinosaur]

I'd prefer if we named this module compat.py - drop the leading underscore.

[Hernrup]

This is great! However I feel that there is a strong chance that some of the older PRs will break this compatibility again. Personally I feel that is it a little hard to contribute at the moment as the branches has diverged allot.

I think this project would get allot more forward momentum if we could get some cleanup on the PRs. Maybe its even better to pull few almost-done once to get back to a steady state to branch from.

What do you think @tomchristie? I know you have allot to do but could we perhaps get a fast cleanup weekend going?

[lovelydinosaur]

@Hernrup If anyone else is around at EuroPython, might be abel to find some time then?

[sloria]

OK, made the style fixes you suggested. Let me know if there's anything more to do.

[Hernrup]

Turns out there are a few packages that has been renamed/changed in py3. The one with the largest impact is probably "SimpleHTTPServer".
I dont have the knowledge to investigate these py3 issues. Do you think you could have a look at that as well in this PR @sloria? Would be very nice to get the py3 support going.

[sloria]

Yep, upon actually trying to run the mkdocs CLI on Py3, I found a few other incompatibilities. I will look these over.

[sloria]

OK, the remaining incompatibilities have been resolved.

[Hernrup]

Very nice! Works like a charm.

Not to push my luck but do you have any suggestions for what to do about #60. It would break the py3 compat if pulled today due to some issues with the libs HTMLParser and markupbase.

[sloria]

@Hernrup If the Py3 builtin HTMLParser and the Py2 backport are fully compatibile, you could add a conditional dependency for Python2 in setup.py.

# setup.py
#...
if int(sys.version)[0] == 2:
    install_requires.append('HTMLParser')

[d0ugal]

I don't think the properties that are not being renamed should be listed like this.

[lovelydinosaur]

Agreed.

[sloria]

This PR is updated with modifications from @d0ugal's code review.

The Travis build is failing, but it seems to be failing on tests that are also failing on master.

Please let me know if any further modifications need to be made in order to merge this.

[d0ugal]

You are right, there are four failing tests in the current master. I had hoped to solve them last week with help from @tomchristie at EuroPython but didn't manage.

Otherwise I think this change looks good.

[Keats]

Any help needed to get that merged?

[d0ugal]

I resolved the failing tests in master yesterday, it looks like that or another change means this now doesn't merge cleanly. So I think this just needs to be rebased and then i think it's good.

[Keats]

ok, @sloria let me know if you don't have time, I can do it

[sloria]

Thanks @d0ugal for fixing those tests. I will get this updated with master later today.

[sloria]

OK, I've rebased on top of master. Ready for merge. Let me know if any other changes are necessary.

[d0ugal]

Awesome! I'll get back to this during the week.

[d0ugal]

Sorry, I missed this one before. We need a future import for print_function in this file.

[d0ugal]

Managed to find time to look through this today, I think this looks great! I spotted one file that is missing the print_function import but otherwise I'm happy to merge it in. Really pleased to see Python 3 support 😄

[sloria]

Added the missing import. Should be good to merge. Thanks for reviewing this.

[d0ugal]

Thanks!