New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path-handling on Windows #121

Merged
merged 2 commits into from Aug 21, 2014

Conversation

Projects
None yet
3 participants
@edbrannin
Contributor

edbrannin commented Aug 17, 2014

This has the same goal as #47, with a different approach. I'm not sure yet which is better.

I'm making this PR to make it easier to compare the results of both approaches directly.

edbrannin added some commits Aug 14, 2014

Windows: Use posixpath in nav.FC.make_absolute()
nav.FileContext.make_absolute() is only used to compare
links to entries in mkdocs.yml, so it makes sense for it
to only use POSIX-style paths.

Without this, the site fails to build because it checks for
a Windows-style path in a list of POSIX paths in
build.PathToURL.__call__().

This is the last change required to build the mkdocs site
on Windows.
@edbrannin

This comment has been minimized.

Contributor

edbrannin commented Aug 17, 2014

I'll try to add some tests for this (starting with the one in #47) soon.

@d0ugal

This comment has been minimized.

Member

d0ugal commented Aug 20, 2014

I'll wait for the tests, but otherwise this sounds reasonable and LGTM.

tomchristie added a commit that referenced this pull request Aug 21, 2014

Merge pull request #121 from edbrannin/windows-paths
Fix path-handling on Windows

@tomchristie tomchristie merged commit 80c9b28 into mkdocs:master Aug 21, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@edbrannin

This comment has been minimized.

Contributor

edbrannin commented Aug 21, 2014

Oh, thank you! I'll keep targeted tests for this on my backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment