Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a title attribute to the search input #1379

Merged
merged 1 commit into from Feb 2, 2018
Merged

Conversation

@Rudloff
Copy link
Contributor

@Rudloff Rudloff commented Jan 16, 2018

Currently the input does not have any label or title which means is is not correctly identified by assistive technologies such as screen reader.
(You can read more about it in this WCAG guideline.)

@waylan
Copy link
Member

@waylan waylan commented Jan 16, 2018

This change should address both of the included themes. Could you add this to the mkdocs theme as well?

As an aside, we'll commit this now (assuming the above request is met) to get the benefits ASAP, but I'm concerned this might get missed/lost in the upcoming search refactor.

@Rudloff Rudloff force-pushed the Rudloff:patch-2 branch from 2a04a28 to 3d4fb39 Jan 16, 2018
@Rudloff
Copy link
Contributor Author

@Rudloff Rudloff commented Jan 16, 2018

I updated my PR. I also added it in readthedocs/search.html (I missed it before).

@waylan waylan added this to the 1.0.0 milestone Feb 2, 2018
@waylan waylan added the Enhancement label Feb 2, 2018
@waylan waylan merged commit 00d0ab9 into mkdocs:master Feb 2, 2018
3 checks passed
3 checks passed
codecov/project 93.66% (target 90%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Rudloff Rudloff deleted the Rudloff:patch-2 branch Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.