Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Safari bug when zooming to < 100% #1389

Merged
merged 1 commit into from Jan 21, 2018

Conversation

@yeraydiazdiaz
Copy link
Contributor

@yeraydiazdiaz yeraydiazdiaz commented Jan 21, 2018

Fixes #1050

Tested on Safari 11.0.2 on Mac OS X Sierra.

Haven't tried with Cinder but I assume it's the same problem, Safari simply ignores the width: 25% of the col-md-3 and pushes the col-md-9 over it. Overriding the padding and width seems to work without affecting other browsers. It's a fairly hideous workaround but aren't they all.

@yeraydiazdiaz yeraydiazdiaz force-pushed the yeraydiazdiaz:fix-safari-bug branch from 79609d3 to 4e0c28b Jan 21, 2018
@yeraydiazdiaz yeraydiazdiaz force-pushed the yeraydiazdiaz:fix-safari-bug branch from 4e0c28b to a42ea69 Jan 21, 2018
@waylan waylan merged commit 6265416 into mkdocs:master Jan 21, 2018
3 checks passed
3 checks passed
codecov/project 93.57% (target 90%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@waylan
Copy link
Member

@waylan waylan commented Jan 21, 2018

@yeraydiazdiaz thanks for these. We don't really have anyone working on front end stuff right now, so any and all help in the area is much appreciated.

@lebigot
Copy link

@lebigot lebigot commented Jan 21, 2018

Thanks @yeraydiazdiaz! Did you report this bug to Apple as well (unless already reported)?

@yeraydiazdiaz
Copy link
Contributor Author

@yeraydiazdiaz yeraydiazdiaz commented Jan 22, 2018

@waylan no worries, thanks to Tom and all the contributors for your efforts :)

@lebigot I haven't, no, I'll see if I can test it on a newer version of Safari first

waylan added a commit to waylan/mkdocs that referenced this pull request Jul 10, 2018
The sidebar was under the left margin of the main content and not 
clickable. This moves the sidebar to the top so it is accessable. Not 
sure when this got broken. Maybe mkdocs#1387 or mkdocs#1389 or mkdocs#1395.
@waylan waylan mentioned this pull request Jul 10, 2018
waylan added a commit that referenced this pull request Jul 10, 2018
The sidebar was under the left margin of the main content and not 
clickable. This moves the sidebar to the top so it is accessable. Not 
sure when this got broken. Maybe #1387 or #1389 or #1395.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.