Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand {sha} and {version} is user commit message #1410

Merged
merged 5 commits into from Feb 22, 2018
Merged

Conversation

@abitrolly
Copy link
Contributor

@abitrolly abitrolly commented Feb 21, 2018

No description provided.

@waylan
Copy link
Member

@waylan waylan commented Feb 21, 2018

Interesting. I didn't even realize this was done with the default message. We should add some documentation that this is supported here.

@waylan
Copy link
Member

@waylan waylan commented Feb 21, 2018

Also, a line should be added to the release notes

@abitrolly
Copy link
Contributor Author

@abitrolly abitrolly commented Feb 22, 2018

Done.

@@ -83,7 +83,7 @@ def common_options(f):
no_reload_help = "Disable the live reloading in the development server."
dirty_reload_help = "Enable the live reloading in the development server, but only re-build files that have changed"
commit_message_help = ("A commit message to use when commiting to the "

This comment has been minimized.

@trel

trel Feb 22, 2018
Contributor

not part of this original PR, but this should also be 'committing' with two t's

@waylan waylan merged commit 0dce2b2 into mkdocs:master Feb 22, 2018
3 checks passed
3 checks passed
codecov/project 93.59% (target 90%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants