Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker search query string #1589

Merged
merged 2 commits into from Aug 13, 2018
Merged

Conversation

@yeraydiazdiaz
Copy link
Contributor

@yeraydiazdiaz yeraydiazdiaz commented Aug 12, 2018

Fixes #1584

We had a copy of initSearch running on document ready in main.js which was causing the race condition with the fetching of the index and initialization.

We now explictly send a message from the initialization code to start off search for the query string if any.

I also tweaked the behaviour of the search input for the RTD theme so it does not reload the page when pressing Enter.

@yeraydiazdiaz yeraydiazdiaz force-pushed the yeraydiazdiaz:worker-search-query-string branch from cabd558 to 10aae4b Aug 12, 2018
@waylan waylan merged commit 7aaf5a6 into mkdocs:master Aug 13, 2018
3 checks passed
3 checks passed
codecov/project 94.5% (target 90%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yeraydiazdiaz yeraydiazdiaz deleted the yeraydiazdiaz:worker-search-query-string branch Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.