Replace inotify with polling observer #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't need to. This is just under the hood stuff that makes the auto-reload work more consistently. |
| @@ -84,7 +85,8 @@ def serve(config, options=None): | |||
| # can re-apply them if the config file is reloaded. | |||
| event_handler = BuildEventHandler(options) | |||
| config_event_handler = ConfigEventHandler(options) | |||
| observer = observers.Observer() | |||
| # Use highly universal `PollingObserver` | |||
There was a problem hiding this comment.
Let's expand on that slightly.
# We could have used `Observer()`, which can be faster, but `PollingObserver()` works more universally.
d0ugal
added a commit
that referenced
this pull request
Oct 30, 2014
Replace inotify with polling observer
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened #178 to discuss my issues running mkdocs inside Docker/Vagrant setups. After talking to a watchdog developer, he suggested using a
PollingObserverwhich is a more universal approach but likely also a little bit slower.I believe these changes will allow auto-reload to work inside shared folders. My brief testing suggests so anyhow. Existing users shouldn't notice any difference.
I absolutely couldn't figure out any sensible way to unit test my four line pull request. I also didn't find any place in the project documentation to write about it.