Build 404 pages from the theme if they exist #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2014
Closed
This change involved breaking up the context generation to create a sub context that can be used for rendering pages not based on a specific Markdown file.
| canonical_url = None | ||
|
|
||
| global_context = get_global_context(nav, config) | ||
| local_context = global_context.copy() |
There was a problem hiding this comment.
Rather than nest these would it be clearer if code using them calls each separately and combines the two dicts?
Maybe cleaner to have that done at the top level, rather than nested in here?
There was a problem hiding this comment.
Good point, I nearly done this but then forgot.
|
@d0ugal works and lgtm. |
|
Thanks! Are you happy with it now @tomchristie? |
|
Yup, fab! |
d0ugal
added a commit
that referenced
this pull request
Nov 11, 2014
Build 404 pages from the theme if they exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.