New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Fixes for MkDocs and ReadTheDocs themes #225

Merged
merged 22 commits into from Nov 17, 2014

Conversation

Projects
None yet
4 participants
@d0ugal
Member

d0ugal commented Nov 16, 2014

A rebased and updated version of #59 by @Hernrup.

@d0ugal d0ugal referenced this pull request Nov 16, 2014

Closed

table style is lost #106

@d0ugal d0ugal added this to the 0.11.0 milestone Nov 16, 2014

@d0ugal d0ugal changed the title from Graphics for readthedocs to Theme Fixes for MkDocs and ReadTheDocs themes Nov 17, 2014

@d0ugal

This comment has been minimized.

Member

d0ugal commented Nov 17, 2014

The changes here have become somewhat convoluted as #59 touched both the RTD theme and the MkDocs theme. Splitting them up at this point is probably more effort than it is worth IMO.

@tomchristie

This comment has been minimized.

Contributor

tomchristie commented Nov 17, 2014

Splitting them up at this point is probably more effort than it is worth IMO.

Fine with me.

d0ugal added some commits Nov 17, 2014

Updated the ReadTheDocs theme to the upstream version
We now have an extra css file for including out changes, we shoudn't
ever edit the theme directly. Updating to the latest version involved
renaming a few font files.
Fixed vertical scroll with large project docs
/HT Thanks to @ngzhian for the fix.

Closes #202 #220
@Hernrup

This comment has been minimized.

Contributor

Hernrup commented Nov 17, 2014

This looks awesome. Thank you @d0ugal for pushing this forward when I didn't have the time to follow through on it.

@d0ugal

This comment has been minimized.

Member

d0ugal commented Nov 17, 2014

@Hernrup Thanks!

@tomchristie I think I covered all your concerns in #59, do you want to give this another review? I think it is good to go otherwise.

@tomchristie

This comment has been minimized.

Contributor

tomchristie commented Nov 17, 2014

In your hands @d0ugal. I'm happy whenever you are.

d0ugal added a commit that referenced this pull request Nov 17, 2014

Merge pull request #225 from d0ugal/graphics-for-readthedocs
Theme Fixes for MkDocs and ReadTheDocs themes

@d0ugal d0ugal merged commit 50798e9 into mkdocs:master Nov 17, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@d0ugal d0ugal deleted the d0ugal:graphics-for-readthedocs branch Nov 18, 2014

@tobegit3hub

This comment has been minimized.

tobegit3hub commented Dec 5, 2014

Hi @d0ugal . We have used some themes like united. Can you fix it for other theme?

@d0ugal

This comment has been minimized.

Member

d0ugal commented Dec 5, 2014

@tobegit3hub fix what exactly? If you have issues with the other themes please submit issues for them.

@tobegit3hub

This comment has been minimized.

tobegit3hub commented Dec 5, 2014

@d0ugal I think we can fix the similar problems in other themes. I will submit issues or patches for them later. Thanks for your great job.

@d0ugal

This comment has been minimized.

Member

d0ugal commented Dec 5, 2014

@tobegit3hub Thanks - it would be good to have a set of issues that highlight specific problems. I'm focusing my effort on the MkDocs and ReadTheDocs themes as I've not had enough time to use the others extensively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment