files structure: move src_paths as a dynamic property, add remove #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waylan
requested changes
Feb 15, 2021
There was a problem hiding this comment.
This looks good. However, we should have some tests added. That fact that we are not getting any failing tests with the below noted issue suggest that we need to add some.
Also, a note should be added to the release notes to alert plugin devs to the change in behavior.
Plugins wishing to manipulate the Files structure have an append method but can't dynamically work on src_paths since it's computed once on Files instanciation This commits allows plugins to manipulate Files trough append and remove of file objects while not having to care about the src_paths since it's now a dynamically computed property
ultrabug
force-pushed
the
files_remove
branch
from
32361e7
to
3e421f1
Compare
|
Thanks @waylan ; tests added |
|
Added mention to release notes; hopefully to the right place Cheers |
waylan
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins wishing to manipulate the Files structure have an append
method but can't dynamically work on src_paths since it's computed
once on Files instanciation
This commits allows plugins to manipulate Files trough append and
remove of file objects while not having to care about the src_paths
since it's now a dynamically computed property