Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'es' themes translations #2396

Merged
merged 2 commits into from May 7, 2021
Merged

Add 'es' themes translations #2396

merged 2 commits into from May 7, 2021

Conversation

@mondeja
Copy link
Contributor

@mondeja mondeja commented May 7, 2021

No description provided.

@waylan
Copy link
Member

@waylan waylan commented May 7, 2021

Awesome! Great to see more translations already. Could you add "Spanish" to the note in the release notes? Also, the language needs to be added to the list of supported languages for each theme in docs/user-guide/choosing-your-theme.md.

We should probably update the translation docs to reflect the need to do that when new locales are added.

@ultrabug
Copy link
Member

@ultrabug ultrabug commented May 7, 2021

@waylan did you ever consider issue templates to address this as a complement to documentation?

- Add Spanish translation supported for each theme in documentation.
- Document that, when a new translation is added for a theme, the documentation about the theme must be updated.
@waylan
Copy link
Member

@waylan waylan commented May 7, 2021

@waylan did you ever consider issue templates to address this as a complement to documentation?

Personally, I hate them when I interact with other projects. Therefore I refuse to inflict them on others. Yes, that is really how I feel about them.

@mondeja
Copy link
Contributor Author

@mondeja mondeja commented May 7, 2021

Could you add "Spanish" to the note in the release notes? Also, the language needs to be added to the list of supported languages for each theme in docs/user-guide/choosing-your-theme.md.

We should probably update the translation docs to reflect the need to do that when new locales are added.

Done in c869947

@waylan waylan merged commit a8ec4b6 into mkdocs:master May 7, 2021
19 of 20 checks passed
@mondeja mondeja deleted the theme-es branch Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants