Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh_CN: Complete the translation of the mkdocs theme #2497

Merged
merged 5 commits into from Jul 15, 2021

Conversation

@xingkong0113
Copy link
Contributor

@xingkong0113 xingkong0113 commented Jul 13, 2021

    Complete translation both
    mkdocs
    and
    readthedocs
    themes.
    
    Signed-off-by: xingkong0113 <26911141+xingkong0113@users.noreply.github.com>
Finish translating both mkdocs and readthedocs topics.

Signed-off-by: xingkong0113 <26911141+xingkong0113@users.noreply.github.com>
@ultrabug
Copy link
Member

@ultrabug ultrabug commented Jul 13, 2021

@xingkong0113 thank you for your contribution!

Could you please add your proposed locale to both mkdocs and readthedocs themes' documentation ?

Cheers

@xingkong0113
Copy link
Contributor Author

@xingkong0113 xingkong0113 commented Jul 13, 2021

@xingkong0113 thank you for your contribution!

Could you please add your proposed locale to both mkdocs and readthedocs themes' documentation ?

Cheers

hi ultrabug
Which file should I change?
thanks

@ultrabug
Copy link
Member

@ultrabug ultrabug commented Jul 13, 2021

@xingkong0113 thanks, please fill the Last-Translator field too

Copy link
Member

@ultrabug ultrabug left a comment

I intend to merge this in 1 day

@ultrabug ultrabug merged commit ccc4ce8 into mkdocs:master Jul 15, 2021
17 checks passed
@ultrabug
Copy link
Member

@ultrabug ultrabug commented Jul 15, 2021

Thanks a lot @xingkong0113 :)

@xingkong0113 xingkong0113 deleted the zh_CN branch Jul 15, 2021
@oprypin
Copy link
Member

@oprypin oprypin commented Jul 16, 2021

@ultrabug You merged this as "Create a merge commit" but you must always select "Squash and merge".

image

@ultrabug
Copy link
Member

@ultrabug ultrabug commented Jul 16, 2021

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants