Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese (ja) translation for built-in themes #2525

Merged
merged 6 commits into from Sep 7, 2021
Merged

Add Japanese (ja) translation for built-in themes #2525

merged 6 commits into from Sep 7, 2021

Conversation

@gh640
Copy link
Contributor

@gh640 gh640 commented Jul 31, 2021

I'd like to add Japanese translation for built-in themes.

  • mkdocs
  • readthedocs

I read the following guides for contribution before I made this PR.

I tested them locally following the instruction https://www.mkdocs.org/dev-guide/translations/#testing-theme-translations and they look fine.

Please let me know if there's anything I missed. Thank you in advance!

@ultrabug ultrabug merged commit 519d2d3 into mkdocs:master Sep 7, 2021
17 checks passed
@ultrabug
Copy link
Member

@ultrabug ultrabug commented Sep 7, 2021

Thank you for your first contribution to this project @gh640 !

@gh640 gh640 deleted the add_ja_translation_for_themes branch Sep 8, 2021
@gh640
Copy link
Contributor Author

@gh640 gh640 commented Sep 8, 2021

@ultrabug Thanks! Yay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants