Add the homepage back to the navigation#271
Conversation
|
@tomchristie Interested in your input on this. My reasoning before was that if we add it, it is hard to remove it. However, I think now that is wrong.
|
|
This will close #236. |
|
Not yet reviews if this should just already be in nav_items, or only in iter as per this fix. |
|
hmm, yeah, I think it should be added to nav_items. Will update. |
cff5f86 to
7eb21c0
Compare
7eb21c0 to
bfdab5f
Compare
|
Ok, this seems pretty solid now. One thing to note, it is technically backwards incompatible as it will change what the theme outputs. In some cases, like in Django REST Framework, it will mean the Home nav item is displayed twice until the one manually added is removed. @tomchristie Thoughts on this? Seem okay to do that in a 0.12 release? |
|
@tomchristie Spotted the above question? |
|
@d0ugal Yeah that's okay, tho probably worth pre-emptively tracking in a REST framework issue. (Apologies for the off-topic bits here) |
|
See encode/django-rest-framework#2246 for the highlighting issue. |
Add the homepage back to the navigation
No description provided.