New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use os.path.sep for Windows support #276

Merged
merged 3 commits into from Dec 10, 2014

Conversation

Projects
None yet
1 participant
@d0ugal
Member

d0ugal commented Dec 8, 2014

No description provided.

@d0ugal d0ugal force-pushed the d0ugal:win-path branch from b93b6e3 to 37240c5 Dec 8, 2014

@d0ugal

This comment has been minimized.

Member

d0ugal commented Dec 8, 2014

@ghuntley can you see if this fixes the issue in #238? You should be able to install and run my branch locally with:

pip install -U https://github.com/d0ugal/mkdocs/archive/win-path.zip
@d0ugal

This comment has been minimized.

Member

d0ugal commented Dec 8, 2014

@Timber232 I've updated this to include the if statement you spotted.

@d0ugal

This comment has been minimized.

Member

d0ugal commented Dec 8, 2014

shot

Seems to work pretty well! Screenshot based on one of the failing examples in #238

@d0ugal d0ugal added this to the 0.12.0 milestone Dec 8, 2014

d0ugal added a commit that referenced this pull request Dec 10, 2014

Merge pull request #276 from d0ugal/win-path
Use os.path.sep for Windows support

@d0ugal d0ugal merged commit 5d07e4c into mkdocs:master Dec 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@d0ugal d0ugal deleted the d0ugal:win-path branch Mar 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment