Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use os.path.sep for Windows support #276

Merged
merged 3 commits into from
Dec 10, 2014
Merged

Use os.path.sep for Windows support #276

merged 3 commits into from
Dec 10, 2014

Conversation

d0ugal
Copy link
Member

@d0ugal d0ugal commented Dec 8, 2014

No description provided.

@d0ugal
Copy link
Member Author

d0ugal commented Dec 8, 2014

@ghuntley can you see if this fixes the issue in #238? You should be able to install and run my branch locally with:

pip install -U https://github.com/d0ugal/mkdocs/archive/win-path.zip

@d0ugal
Copy link
Member Author

d0ugal commented Dec 8, 2014

@Timber232 I've updated this to include the if statement you spotted.

@d0ugal
Copy link
Member Author

d0ugal commented Dec 8, 2014

shot

Seems to work pretty well! Screenshot based on one of the failing examples in #238

@d0ugal d0ugal added this to the 0.12.0 milestone Dec 8, 2014
d0ugal added a commit that referenced this pull request Dec 10, 2014
@d0ugal
Merge pull request #276 from d0ugal/win-path
5d07e4c 
Use os.path.sep for Windows support
@d0ugal d0ugal merged commit 5d07e4c into mkdocs:master Dec 10, 2014
@d0ugal d0ugal deleted the win-path branch March 27, 2015 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
1 participant
@d0ugal