Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an extra space to the readthedocs theme breadcrumbs. #2810

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Added an extra space to the readthedocs theme breadcrumbs. #2810

merged 3 commits into from
Mar 31, 2022

Conversation

peymanr34
Copy link
Contributor

In the readthedocs theme, the breadcrumbs of the last item needs an extra space.

Before:
image

After:
image

I hope you don't mind I didn't open an issue first.

oprypin
oprypin approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! This is indeed a regression in 1.3.0.
I modified the fix, though. It was enough to add whitespace that isn't nbsp

@oprypin oprypin merged commit cdf8a26 into mkdocs:master Mar 31, 2022
howird pushed a commit to howird/mkdocs that referenced this pull request May 14, 2022
@peymanr34 @oprypin @howird
Added an extra space to the readthedocs theme breadcrumbs (mkdocs#2810)
17f8504 
Co-authored-by: Oleh Prypin <oleh@pryp.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oprypin oprypin oprypin approved these changes

@ultrabug ultrabug ultrabug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peymanr34 @oprypin @ultrabug