New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TOC processing cutting off Markdown content #294

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jdhoek

jdhoek commented Dec 19, 2014

The footnotes Python-Markdown extension appends a HTML div containing
the footnotes to the end of the generated HTML. This commit prevents the
toc class from accidentally moving that div to the TOC HTML output
instead of the main HTML output.

Fix TOC processing cutting off Markdown content
The `footnotes` Python-Markdown extension appends a HTML div containing
the footnotes to the end of the generated HTML. This commit prevents the
`toc` class from accidentally moving that div to the TOC HTML output
instead of the main HTML output.
@jdhoek

This comment has been minimized.

jdhoek commented Dec 19, 2014

I'm not too well-versed in Python development, so this pull-request may be lacking in that respect. This code works, but I would like to add a test for this use case (using the footnotes Python Markdown extension) as well, how do I run the test suite? (Or, where can I find out how to do so?)

@d0ugal

This comment has been minimized.

Member

d0ugal commented Dec 19, 2014

This change doesn't seem to be quite right, a bunch of tests are failing because there is now some extra HTML. https://travis-ci.org/tomchristie/mkdocs/jobs/44571618

I can't see the reason, but lots of the failures are due to an extra \n</p> being added to the end of the HTML.

@d0ugal

This comment has been minimized.

Member

d0ugal commented Dec 19, 2014

Have you tested this change without enabling the footnotes extension?

@jdhoek

This comment has been minimized.

jdhoek commented Dec 19, 2014

Hmm, that seems to break the TOC… I'll resubmit this pull request after refining the fix.

@d0ugal

This comment has been minimized.

Member

d0ugal commented Dec 19, 2014

Thanks :) Once we get the current tests passing I'll help you add a new one if we need it.

@d0ugal d0ugal added the Bug label Dec 19, 2014

@d0ugal

This comment has been minimized.

Member

d0ugal commented Jan 12, 2015

Closing this for now, happy to consider an updated version if you get time.

@d0ugal d0ugal closed this Jan 12, 2015

@jniggemann jniggemann referenced this pull request Jan 14, 2015

Closed

footnote text missing #329

@d0ugal d0ugal referenced this pull request Jan 15, 2015

Closed

fixes #329 and #294 #330

@jdhoek jdhoek referenced this pull request Jan 16, 2015

Merged

removes TOC tag creation #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment