-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Switch to pyproject.toml and Hatch build #2988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
What about something like this? https://github.com/facelessuser/Rummage/blob/master/pyproject.toml#L98 |
ofek
reviewed
Oct 4, 2022
mondeja
reviewed
Oct 4, 2022
ofek
reviewed
Oct 4, 2022
ofek
approved these changes
Oct 4, 2022
Sigh, still really scared about losing the "Used by" section, but let's hope for the best |
Success, it's still there 🙂 |
For now, anyway 🙂 |
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest remaining issues:
I can't actually remove
setup.py
because we have commands that require it:E.g.
python setup.py compile_catalog -t mkdocs
setuptools
says: