Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page titles no longer contain the site name #299

Merged
merged 1 commit into from Jan 3, 2015
Merged

Conversation

@samhatfield
Copy link
Contributor

@samhatfield samhatfield commented Dec 22, 2014

If a page has a specific title, page_title will contain this and only
this. If the page has no title, or is the homepage, page_title will be
None. The <title> tag will always display at least the site name.

All of the themes' base.html files have been updated accordingly.

If a page has a specific title, `page_title` will contain this and only
this. If the page has no title, or is the homepage, `page_title` will be
`None`. The `<title>` tag will always display at least the site name.

All of the themes' base.html files have been updated accordingly.
@d0ugal
Copy link
Member

@d0ugal d0ugal commented Dec 22, 2014

cool, my main concern is backards compatability. Custom themes could loose the site name, if this is just made clear in the release notes I think it should be okay tho' - not exactly a big issue.

@d0ugal d0ugal added this to the 0.12.0 milestone Dec 22, 2014
@d0ugal d0ugal added the Cleanup label Dec 22, 2014
d0ugal added a commit that referenced this pull request Jan 3, 2015
Page titles no longer contain the site name
@d0ugal d0ugal merged commit 0575d86 into mkdocs:master Jan 3, 2015
1 check passed
1 check passed
@tomchristie
continuous-integration/travis-ci The Travis CI build passed
Details
@d0ugal
Copy link
Member

@d0ugal d0ugal commented Jan 3, 2015

Decided the risk is minimal - will document this in the release notes for 0.12. Thanks @samhatfield!

@samhatfield
Copy link
Contributor Author

@samhatfield samhatfield commented Jan 3, 2015

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants