Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have slash at end of all page links #344

Merged
merged 2 commits into from Mar 7, 2015
Merged

Have slash at end of all page links #344

merged 2 commits into from Mar 7, 2015

Conversation

@rkday
Copy link
Contributor

@rkday rkday commented Feb 7, 2015

As discussed in readthedocs/readthedocs.org#1101, this makes directory links consistently have a trailing slash.

It looks like the fix for Python 2.6 in f437ab0 could strip off suffix in addition to the additional / it was meant to remove - I've just switched the order so that suffix is appended after rstrip('/') is called.

I've also added a test (which failed without my fix).

@d0ugal d0ugal added this to the 0.12.0 milestone Mar 7, 2015
@d0ugal d0ugal added the Bug label Mar 7, 2015
d0ugal added a commit that referenced this pull request Mar 7, 2015
Have slash at end of all page links
@d0ugal d0ugal merged commit 3fcd2ea into mkdocs:master Mar 7, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@d0ugal
Copy link
Member

@d0ugal d0ugal commented Mar 7, 2015

Good catch!

@ghost ghost mentioned this pull request Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants