Fix cross-platform encoding issues. #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using io.open and explicitly defining the encoding on the call to open every time, we should get consistant behavior across platforms as open will not rely on each individual system's local settings to determine what encoding to use. Note that io.open is an alias to the built-in open function in Python 3. In Python 2.6+ it is a Python 3 compatable implementation which works in Python 2. In the future when all support for Python 2 is dropped, simply delete the import statements with no additional changes to the code. I expect this will fix both mkdocs#239 and mkdocs#352.
This was referenced Apr 7, 2015
|
Neat! This makes lots of sense to me. I'll wait a little bit to see if anyone comments on it helping, or not, but otherwise I'm happy to merge it anyway. |
d0ugal
added a commit
that referenced
this pull request
Apr 8, 2015
Fix cross-platform encoding issues.
|
I'm testing in a Windows VM and this seems to help, or at least, not cause further issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using io.open and explicitly defining the encoding on the call to
open every time, we should get consistant behavior across platforms
as open will not rely on each individual system's local settings
to determine what encoding to use. Note that io.open is an alias
to the built-in open function in Python 3. In Python 2.6+ it is a
Python 3 compatable implementation which works in Python 2. In the
future when all support for Python 2 is dropped, simply delete the
import statements with no additional changes to the code.
I expect this will fix both #239 and #352.