Preserve order of Python Markdown extensions #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python Markdown inclusion order can be important when including various custom extensions. Conflicts can arise as to where extensions get inserted in the workflow. By preserving order of how extensions are defined in the settings file, this can allow a user to control insertion order and work around these issues. As Py26 supported is noted to be removed in the future, I saw no reason to add additional dependencies for OrderedDict. Try catch statements can be removed when Py26 support is removed.
| @@ -67,3 +68,34 @@ def test_create_media_urls(self): | |||
| for path, expected_result in expected_results.items(): | |||
| urls = utils.create_media_urls(site_navigation, [path]) | |||
| self.assertEqual(urls[0], expected_result) | |||
|
|
|||
There was a problem hiding this comment.
Rather than try/catching in the unittest I'd prefer:
@unittest.skipIf(sys.version_info[:2] == (2, 6))
There was a problem hiding this comment.
I don't think the Py26 unittest lib has skipIf. Seems to be new in Py31 https://docs.python.org/3/library/unittest.html#skipping-tests-and-expected-failures.
There was a problem hiding this comment.
Ah, of course, sorry. It is in py27 but not py26, so nevermind!
There was a problem hiding this comment.
Yeah, I was just about to correct about the Py31 to Py27. But yeah, it would have been much cleaner.
|
One mine comment, otherwise happy to merge this. Thanks! |
d0ugal
added a commit
that referenced
this pull request
Apr 28, 2015
Preserve order of Python Markdown extensions
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python Markdown inclusion order can be important when including various custom extensions. Conflicts can arise as to where extensions get inserted in the workflow. By preserving order of how extensions are
defined in the settings file, this can allow a user to control insertion order and work around these issues. As Py26 supported is noted to be removed in the future, I saw no reason to add additional dependencies for OrderedDict. Try catch statements can be removed when Py26 support is removed.