Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode files #542

Merged
merged 2 commits into from May 21, 2015
Merged

Unicode files #542

merged 2 commits into from May 21, 2015

Conversation

@d0ugal
Copy link
Member

@d0ugal d0ugal commented May 21, 2015

No description provided.

@d0ugal d0ugal added the Bug label May 21, 2015
@d0ugal d0ugal added this to the 0.13.0 milestone May 21, 2015
project_dir = os.path.join(TEST_PROJECTS, project)
out = os.path.join(output, project)
command = ['mkdocs', 'build', '--site-dir', out]
subprocess.check_call(command, cwd=project_dir)

This comment has been minimized.

@d0ugal

d0ugal May 21, 2015
Author Member

This is where I ran into #543. I set the cwd, otherwise whatever config I specified, it build the MkDocs documentation as I was at the root of the repo.

d0ugal added 2 commits May 21, 2015
This then means that all the file walking operations in Python 2 return
unicode, and thus, we can support unicode filenames.

Closes #532
@d0ugal d0ugal force-pushed the d0ugal:unicode-files branch from 6d2f2d3 to 6679927 May 21, 2015
d0ugal added a commit that referenced this pull request May 21, 2015
@d0ugal d0ugal merged commit be83950 into mkdocs:master May 21, 2015
3 checks passed
3 checks passed
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.89%) to 92.98%
Details
@d0ugal d0ugal deleted the d0ugal:unicode-files branch May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant