CLI improvements #579
Merged
CLI improvements #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. There is a minor flake8 nit and can you add to the release notes. I created an entry for 0.14 in master. |
Updated release notes.
The --quiet and --verbose options can be called from any command (parent or subcommands), yet they are only defined once. Code adapted from: pallets/click#108 (comment) If either or both options are defined more than once by the user, the last option defined is the only one which controls. No support of -vvv to increase verbosity. MkDocks only utilizes a few loging levels so the additional control offers no real value. Can always be added later. Updated release notes.
|
@d0ugal I've made the requested changes and this should be ready to go. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-a) to most options.--quietoption which silences INFO and WARNINGS.--quietand--verbosecommon options to all subcommands (yet only defined once). For backward compat, they also work on themkdocsparent command - although perhaps they should be removed from there. If you agree, let me know and I'll add that change to the PR.