New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI improvements #579

Merged
merged 2 commits into from Jun 2, 2015

Conversation

Projects
None yet
2 participants
@waylan
Member

waylan commented Jun 2, 2015

  • Added short options (-a) to most options.
  • Added a --quiet option which silences INFO and WARNINGS.
  • Made --quiet and --verbose common options to all subcommands (yet only defined once). For backward compat, they also work on the mkdocs parent command - although perhaps they should be removed from there. If you agree, let me know and I'll add that change to the PR.

@waylan waylan force-pushed the waylan:cli branch from 68774bc to f79cc2a Jun 2, 2015

@d0ugal

This comment has been minimized.

Member

d0ugal commented Jun 2, 2015

Looks good to me. There is a minor flake8 nit and can you add to the release notes. I created an entry for 0.14 in master.

@d0ugal d0ugal added this to the 0.14.0 milestone Jun 2, 2015

@d0ugal d0ugal added the Enhancement label Jun 2, 2015

waylan added some commits Jun 1, 2015

Add short options (`-a`) to CLI.
Updated release notes.
Added common options to CLI: -q & -v.
The --quiet and --verbose options can be called from any command (parent or
subcommands), yet they are only defined once. Code adapted from:
pallets/click#108 (comment)

If either or both options are defined more than once by the user, the last
option defined is the only one which controls.

No support of -vvv to increase verbosity. MkDocks only utilizes a few
loging levels so the additional control offers no real value. Can always
be added later.

Updated release notes.

@waylan waylan force-pushed the waylan:cli branch from f79cc2a to 96b9814 Jun 2, 2015

@waylan

This comment has been minimized.

Member

waylan commented Jun 2, 2015

@d0ugal I've made the requested changes and this should be ready to go.

d0ugal added a commit that referenced this pull request Jun 2, 2015

Merge pull request #579 from waylan/cli
CLI improvements

@d0ugal d0ugal merged commit 61a0088 into mkdocs:master Jun 2, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@d0ugal

This comment has been minimized.

Member

d0ugal commented Jun 2, 2015

Thanks!

@waylan waylan deleted the waylan:cli branch Jun 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment