Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of search index generation #60

Closed
wants to merge 4 commits into from

Conversation

Hernrup
Copy link
Contributor

@Hernrup Hernrup commented Mar 27, 2014

Solves #1

Note, only generation of search index (Tipue style). No theme views have been implemented.

@@ -6,3 +6,4 @@ htmlcov/
mkdocs.egg-info/
*.pyc
.coverage
.idea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As other comment, let's keep these out, as they're really user-specific.

@tomchristie
Copy link
Contributor

I've not fully reviewed, but looking great!
Needs some tests, ofc.

@Hernrup
Copy link
Contributor Author

Hernrup commented Mar 31, 2014

Thanks for the feedback! I'm not very experienced in python and have a few "best-practices" to catch up on. Ill fix it right up.

@Hernrup
Copy link
Contributor Author

Hernrup commented Mar 31, 2014

I'm having some trouble running the tests under windows. Have you tested that and do you have any feedback on how to set that up? Currently im running into issues with some tempfiles that does not/can not exist under windows.

@SvenDowideit
Copy link

I've added a simple UI - see Hernrup#1

@Hernrup @tomchristie I'm developing this using a Docker container (ie, a boot2docker vm running on my windows box) would you be interested in my making a PR to add the Dockerfile and instructions to this project?

@SvenDowideit
Copy link

we need to make sure that the title, and pagecontent in the generated json file does not contain any ^ characters - see https://github.com/Tipue/Tipue-Search/issues/1 (I'll make a PR on your branch @Hernrup )

Hernrup#2

@Hernrup
Copy link
Contributor Author

Hernrup commented Jun 20, 2014

Ah! Good catch @SvenDowideit :)
I hope to get some more time soon to push these PRs forward. As of now im having alot of trubble getting the tests to pass on my environment. I guess its some configuration issue.

@Hernrup
Copy link
Contributor Author

Hernrup commented Jul 10, 2014

Turns out this solution is based on HTMLparser lib which will not work on python3. If someone has another lib that might work you are welcome to give it a shot.
This PR feels a little doomed.

@Hernrup Hernrup mentioned this pull request Jul 11, 2014
@d0ugal d0ugal mentioned this pull request Nov 14, 2014
@d0ugal
Copy link
Member

d0ugal commented Nov 14, 2014

Closing in favour of #222 which builds on the changes in this PR.

@d0ugal d0ugal closed this Nov 14, 2014
@d0ugal d0ugal mentioned this pull request Apr 15, 2015
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants