-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for extra_css and extra_javascript in all the themes #90
Conversation
This change looks good to me, I think a test would be useful to verify it is working with one of the themes. If nothing else it'll stop us getting into this situation again. |
I like tests! What's the best way to write a test for this? |
@jimporter I just saw this after opening #135. You may wish to consider the same change from
to
(with appropriate leading whitespace), which generates prettier HTML. |
@zoombody Noted. If your PR lands, I'll be sure to update this one. Still not sure where tests for this should go, though... |
Also, since dc84d21 the use of full URLs is allowed in |
I updated and noticed that 7167406 totally broke the custom themes, since I'll file a new PR for that. |
Looks good, could you add the extra_javascript that are missing as well ? (also +1 for @zoombody use of {%-) |
I think practicality wins over purity here, we don't need a test. I'll give this a manual test next week. |
Ok, I updated this to include |
0464f19
to
6c33fe8
Compare
Sorry for the tardy followup. |
Add support for extra_css and extra_javascript in all the themes
I noticed that most of the themes don't actually support
extra_css
. I think I saw you mention that these themes would eventually be removed from mkdocs core and be turned into add-ons or something, but in the meantime, I think it makes sense to maintain feature parity across the themes.I'm not sure if you'd like tests for this, but if you do, just let me know and I'll try to figure something out.